Skip to content

fix(server): battery alerts when low, not when charged - #1675

Merged
lollipopkit merged 1 commit into
mainfrom
fix/battery-alert
Oct 9, 2026
Merged

fix(server): battery alerts when low, not when charged#1675
lollipopkit merged 1 commit into
mainfrom
fix/battery-alert

Conversation

@lollipopkit

@lollipopkit lollipopkit commented Oct 9, 2026 •
edited by winnowl Bot
Loading

Copy link
Copy Markdown
Owner

Fixes #1673

Summary

Changes

  • Align server card readings and alerts: Keeps card readings in the same order as the detail page, avoids counting network speed twice when choosing the extra slot, and applies a low-charge alert only to discharging batteries. Tests cover slot selection, ordering, and battery status.

@winnowl

winnowl Bot commented Oct 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review completed

Reviewed commit f9a1e02; the results are in the review on this pull request.

Merge risk: 🟢 Low · no blocking findings

📝 Walkthrough
  • Align server card readings and alerts: Keeps card readings in the same order as the detail page, avoids counting network speed twice when choosing the extra slot, and applies a low-charge alert only to discharging batteries. Tests cover slot selection, ordering, and battery status.
  • Review again

Commenting @winnowl review does the same.

@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 67073258-14c0-4aa8-b0da-94f1c8e15ce5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

winnowl[bot]
winnowl Bot approved these changes Oct 9, 2026
View reviewed changes

@winnowl winnowl Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

✅ No blocking issues found — approving.

ℹ️ Review info
⚙️ Run configuration

Configuration: defaults

Review profile: balanced

Model: gpt-6-luna

📥 Commits

Reviewing files that changed between 20d11b3 and f9a1e02.

📒 Files selected for processing (2)
  • lib/view/page/server/card/metric.dart
  • test/unit/server/server_card_readings_test.dart

Coverage

  • 1 of 1 areas reviewed

@lollipopkit
lollipopkit marked this pull request as ready for review October 9, 2026 15:03
@lollipopkit
lollipopkit merged commit b914b15 into main Oct 9, 2026
19 checks passed
@lollipopkit lollipopkit mentioned this pull request Oct 9, 2026
Closed
@lollipopkit
lollipopkit deleted the fix/battery-alert branch October 9, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@winnowl winnowl[bot] winnowl[bot] approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug?] 笔记本电池电量高于 85% 时触发黄色告警

1 participant

@lollipopkit